search

SCasanova / f1dataR

An R package to access Formula 1 Data from the Ergast API and the unofficial F1 data stream via the fastf1 python library.
https://scasanova.github.io/f1dataR/
Other
52 stars 5 forks source link

Deprecating support of FastF1 < 3.1.0 #220

Closed pbulsink closed 7 months ago

pbulsink commented 7 months ago

Closes #198.

codecov[bot] commented 7 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (fbd1213) 90.20% compared to head (3660c78) 95.62%.

:exclamation: Current head 3660c78 differs from pull request most recent head 8833bc9. Consider uploading reports for the commit 8833bc9 to get more accurate results

Files Patch % Lines
R/utils.R 90.90% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #220 +/- ## ========================================== + Coverage 90.20% 95.62% +5.42% ========================================== Files 19 19 Lines 643 594 -49 ========================================== - Hits 580 568 -12 + Misses 63 26 -37 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

pbulsink commented 7 months ago

Also includes random testing fixes (#92ec9ec), cleanup (#0d70687) and a code style optimization (#bbd0402) that I stumbled over while deprecating ff1 < 3 and working on the related tests for deprecation.

pbulsink commented 7 months ago

@SCasanova ready for review, I'd appreciate a quick look to make sure I didn't miss anything in deprecating.

Feel free to merge this whenever you're ready.

SCasanova commented 7 months ago

Will do