SCasanova / f1dataR

An R package to access Formula 1 Data from the Ergast API and the unofficial F1 data stream via the fastf1 python library.

https://scasanova.github.io/f1dataR/

Other

52 stars 5 forks source link

CRAN (and weekly build check) Failures #228

Closed pbulsink closed 6 months ago

pbulsink commented 6 months ago

Per email from CRAN, also found here: https://github.com/SCasanova/f1dataR/actions/runs/8134930400

pbulsink commented 6 months ago

With #229 we should be more stable to Ergast changes, but should still enable testing against failed internet connection.

pbulsink commented 6 months ago

Note this possible option, once the issue is resolved. https://github.com/nealrichardson/httptest2/issues/34.

This should be easier than writing in escape hatches.

pbulsink commented 6 months ago

233 ready for review. Once done, we'll need to do a bugfix X.X.1 version bump (no change in user functionality) and push to CRAN before the deadline next week.

SCasanova commented 6 months ago

Can you recompile vignettes with dpi = 250 instead of 300, please @pbulsink? We're over the limit on CRAN and for the life of me I can't get optipng to work properly on my machine

ideally in #241

pbulsink commented 6 months ago

Will do tonight. Want me to do #227 also?

SCasanova commented 6 months ago

Thanks for #227, please ignore #241, i made a mess In that branch

pbulsink commented 6 months ago

Closed by #237