search

SCasanova / f1dataR

An R package to access Formula 1 Data from the Ergast API and the unofficial F1 data stream via the fastf1 python library.
https://scasanova.github.io/f1dataR/
Other
52 stars 5 forks source link

Version bump and submission #238

Closed SCasanova closed 6 months ago

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.31%. Comparing base (cbf0d0c) to head (55d1e72).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #238 +/- ## ======================================= Coverage 95.31% 95.31% ======================================= Files 19 19 Lines 641 641 ======================================= Hits 611 611 Misses 30 30 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

pbulsink commented 6 months ago

You should add .DS_Store to .gitignore instead of have it in the repo. You'll have to delete this one, commit the deletion, and commit the .gitignore change.

pbulsink commented 6 months ago

This PR puts the version at 1.4.1 but we're currently at 1.5.0 in the repo

pbulsink commented 6 months ago

It might be easier to use a new dev branch, and discard this one, instead of having the PR carry the extra multiple_driver_telem code addition/subtraction and be behind in version num (plus removing the .DS_Store and fixing the out-of-date fastf1)

SCasanova commented 6 months ago

Yeah good idea