search

SCasanova / f1dataR

An R package to access Formula 1 Data from the Ergast API and the unofficial F1 data stream via the fastf1 python library.
https://scasanova.github.io/f1dataR/
Other
52 stars 5 forks source link

Removed Ergast check from `get_current_season()` #242

Closed pbulsink closed 6 months ago

pbulsink commented 6 months ago

Updated Test and News to match. Closes #227

pbulsink commented 6 months ago

@SCasanova I completely removed the ergast check from get_current_season(), it now just takes the current year as the season (or the previous year in January/February, since 'future' stuff doesn't usually come available until March). I could be easily convinced to change that to just be returning the current year, if you think that's better.

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.27%. Comparing base (ba7f1cf) to head (a6629b8).

:exclamation: Current head a6629b8 differs from pull request most recent head 9cc2bcd. Consider uploading reports for the commit 9cc2bcd to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #242 +/- ## ========================================== - Coverage 95.31% 95.27% -0.05% ========================================== Files 19 19 Lines 641 635 -6 ========================================== - Hits 611 605 -6 Misses 30 30 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

SCasanova commented 6 months ago

Perfect, thank you