search

SCasanova / f1dataR

An R package to access Formula 1 Data from the Ergast API and the unofficial F1 data stream via the fastf1 python library.
https://scasanova.github.io/f1dataR/
Other
52 stars 5 forks source link

Minor wording change for clarity #249

Closed SCasanova closed 5 months ago

SCasanova commented 5 months ago

I removed one (1) word, which in my opinion makes it easier to read. Also attempted to precompile before remembering I couldn't get the optimized pngs working.

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.27%. Comparing base (ed0c0c9) to head (66fd67f).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #249 +/- ## ======================================= Coverage 95.27% 95.27% ======================================= Files 19 19 Lines 635 635 ======================================= Hits 605 605 Misses 30 30 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

pbulsink commented 5 months ago

I think if you change the word in both the .Rmd.orig and .Rmd file, you can get away without actually regenerating the vignettes. If you start a new dev branch from master, make the changes, and do just that there won't be so much 'other' in the PR (like modification of the NEWS.md file, cran submission and comments file, the image w/o optimpng, etc).