SCasanova / f1dataR

An R package to access Formula 1 Data from the Ergast API and the unofficial F1 data stream via the fastf1 python library.
https://scasanova.github.io/f1dataR/
Other
54 stars 5 forks source link

## [Codecov] Report #42

Closed pbulsink closed 1 year ago

pbulsink commented 1 year ago

As per below suggestion from #41, suggest integrating codecov for test coverage purposes.

         ## [Codecov](https://app.codecov.io/gh/SCasanova/f1dataR/pull/41?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) Report

:exclamation: No coverage uploaded for pull request base (master@08a12a2). Click here to learn what that means. The diff coverage is n/a.

:exclamation: Current head 4671abd differs from pull request most recent head 01965e4. Consider uploading reports for the commit 01965e4 to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff            @@
##             master      #41   +/-   ##
=========================================
  Coverage          ?   93.54%           
=========================================
  Files             ?       16           
  Lines             ?      341           
  Branches          ?        0           
=========================================
  Hits              ?      319           
  Misses            ?       22           
  Partials          ?        0           

Originally posted by @codecov-commenter in https://github.com/SCasanova/f1dataR/issues/41#issuecomment-1535540702

pbulsink commented 1 year ago

Could also put a codecov badge on the main page.

SCasanova commented 1 year ago

I'm a little unclear on what we need to do here specifically

pbulsink commented 1 year ago

I think just 'installing' codecov to your github profile and enabling it for this repo would end the warning that appears after the 📣 symbol. If you click the link under Github App Integeration it should guide you through that install.

It's a change in authorization protocol for codecov that will soon end the OAuth connection and rely on a more native github integration.

SCasanova commented 1 year ago

Perfect thanks. This should be fixed now then!