SCherkasov MyPlayground issues

SCherkasov / MyPlayground

0 stars 0 forks source link

issues

Newest

Newest Most commented Recently updated Oldest Least commented Least recently updated

The lines which are not using assert or which do not serve for assert needs should be deleted

#15 igavrysh opened 6 years ago
0
Never enter two expressions on the same line, separate lines a never use ";" in Swift

#14 igavrysh closed 6 years ago
1
Never enter two expression on the same line, separate lines a never use

#13 igavrysh closed 6 years ago
0
You don't need to reassign side, it has already been initialized in super init

#12 igavrysh closed 6 years ago
2
You should not store side variable in Square class, take it from parent class, Rectangle

#11 igavrysh closed 6 years ago
2
area and perimeter for Square are already implemented in Reactangle parent class.

#10 igavrysh closed 6 years ago
2
Make Shape and its adapters to adhere to NSCopying protocol

#9 igavrysh opened 6 years ago
3
Make area and perimeter as calculable properties, with getters

#8 igavrysh closed 6 years ago
4
Square is a Rectangle with width equal height, remove hardcoding for "2" value

#7 igavrysh closed 6 years ago
3
Whenever you use object variable inside its class, always use self.variable_name reference

#6 igavrysh closed 6 years ago
1
Change places for super.init and variable assigning, super initialization should go first.

#5 igavrysh closed 6 years ago
1
Use assert(...) here for checking your code

#4 igavrysh opened 6 years ago
2
Use pow(..., 2) function here

#3 igavrysh closed 6 years ago
1
"part" argument should be renamed to "side"

#2 igavrysh closed 6 years ago
1
Square should be inherited from Rectangle

#1 igavrysh closed 6 years ago
1