search

SChernykh / p2pool

Decentralized pool for Monero mining
GNU General Public License v3.0
1.03k stars 124 forks source link

add more configurations; add statistics webserver #181

Closed bladedoyle closed 1 year ago

bladedoyle commented 2 years ago

Enhanced the configuration. Added more config options for p2pool, monero, and xmrig Added a p2pool server statistics webserver container that is activated by "Enable Server Statistics" option (default is enabled). A few random fixes and README.md updates.

Note: This is the extent of the options I plan to add (unless there are specific requests, or p2pool adds new options).

Titaniumtown commented 2 years ago

Why is the statistics webserver only for docker? Maybe this could be also integrated into p2pool itself if possible

bladedoyle commented 2 years ago

@Titaniumtown Because this version of the statistics webserver is written in Python integration into the p2pool C++ codebase is not possible.

I could make it easy to use the statistics webserver with a non-dockerized p2pool instance if there is interest and SChernykh agrees. This would involve adding code to make it a python package, and pushing releases to PyPi for easy installation. If it were not exclusive to docker-compose we would want to move the code up into the project root (p2pool/statistics-webserver or similar), and add instructions to the main README.

Im happy to work on that if there is interest. If so, I propose those changes as a separate PR.

bladedoyle commented 2 years ago

image

bladedoyle commented 2 years ago

Good Grief. I still cant figure out how to use git properly.
I needed to make a change to the mount attribute for p2pool data into statistics container and made a bit of a mess as usual. Anyway, I think I finally got this branch updated with master and the change I needed is added.

bladedoyle commented 2 years ago

Oops, one small change needed for default configuration - should not include my own rpc login :)

SChernykh commented 2 years ago

I'll merge it after v2.2.1 release.

bladedoyle commented 1 year ago

I am removing the health check from the monero container since: 1) you fixed the p2pool hangs on startup when monero rcp isnt listening issue and 2) too many syslog messages: https://github.com/docker/for-linux/issues/679 (which is "resolved" but not "fixed")

bladedoyle commented 1 year ago

healthcheck removal complete. Ready to merge.