search

SChernykh / p2pool

Decentralized pool for Monero mining
GNU General Public License v3.0
1.03k stars 124 forks source link

Add mouse scroll support #216

Closed icsterm closed 1 year ago

icsterm commented 1 year ago

Looks like the mouse scroll is not implemented at all. This works fine with xmrig and monerod, but not in p2pool. Can we have this improvement in further builds?

SChernykh commented 1 year ago

Mouse scroll? P2Pool is a simple console application, it doesn't mess with things like this.

icsterm commented 1 year ago

Well, scrolling with the physical scroll button works in monerod and xmrig, just p2pool has this way of display out. Any chance to make it happen in a further build?

SChernykh commented 1 year ago

I don't understand what you're talking about. Mouse scroll works fine for me in all 3 of these programs.

icsterm commented 1 year ago

For me, using the mouse scroll wheel does nothing, i have to click the scroll bar and move it see the previous output logs.

p2pool

I run the app from a bat file:

p2pool.exe --host 127.0.0.1 --zmq-port 18084 --rpc-port 18081 --wallet xxx --stratum 0.0.0.0:31337 --loglevel 1 --no-randomx --no-cache --light-mode --mini pause

Its weird, the same problem when ssh-ing into a Debian box, scroll wheel doesn't work there as well, so it's not shell related.

This is from build 2.3 up until 2.5 happening, even after several OS reboots, so I can reproduce 100%.

Maybe I need to adjust the scroll line number in Windows to default?

image

SChernykh commented 1 year ago

Mouse scroll? P2Pool is a simple console application, it doesn't mess with things like this.

I was wrong, it does. Fixed in https://github.com/SChernykh/p2pool/commit/1fa6a7c11aac5cade2c18308ace395ac62157ad4