search

SChernykh / p2pool

Decentralized pool for Monero mining
GNU General Public License v3.0
1.03k stars 123 forks source link

Mac OS ARM - P2Pool 3.6.1 fails to run #274

Closed nullifiedtoast closed 10 months ago

nullifiedtoast commented 10 months ago

3.6.1 seems to build and start up just fine, however the longest I have gotten it to run for was 1 minute 16 seconds with the usually time of 5-7 seconds before it suddenly just stops with the exit code of failed. However there is absolutely nothing being shown in the logs about any errors. Everything looks normal and like 3.5 did and then it just abruptly stops.

SChernykh commented 10 months ago

Did you build it yourself, or use the release binary?

nullifiedtoast commented 10 months ago

I have tried both options, as well as trying to let Gupax update its bundled version and test that one. All three are doing the same thing with no reason given in the logs for the abrupt exit.

SChernykh commented 10 months ago

What's the version of your MacOS SDK? There is a known issue with macOS arm builds: https://github.com/monero-project/monero/issues/8657#issuecomment-1331416941

But does P2Pool v3.5 release binary work fine?

nullifiedtoast commented 10 months ago

The SDK is 13.3 and the v3.5 does work just fine and is what I am still currently using.

SChernykh commented 10 months ago

So it probably means that the new way release binaries are built also uses new MacOS SDK, this is unfortunate. I'll have to revert to the previous build script for MacOS ARM binaries.

nullifiedtoast commented 10 months ago

I shall await patiently for the next patch to be released and try to update from v3.5 then. Thank you for all your hardwork and dedication towards helping the monero community!

SChernykh commented 10 months ago

@nullifiedtoast It should be fixed in https://github.com/SChernykh/p2pool/releases/tag/v3.6.2

nullifiedtoast commented 10 months ago

I tried both the release binary and building from source again and they both still only run for about 20 seconds before the exit with the failed code. Once again checked the logs and it shows it running normal and then just abruptly stops again.

nullifiedtoast commented 10 months ago

Built from source runs for about 20-30 seconds and the release binary doesn't even want to start it immediately throws the failed exit code

SChernykh commented 10 months ago

@nullifiedtoast can you test the binary in the attachment? If this one doesn't work, then I don't know what changed since v3.5 p2pool.gz

nullifiedtoast commented 10 months ago

The version you just sent me started up and is running just like the v3.5 was with no issues

SChernykh commented 10 months ago

Good. So it has something to do with LTO (link-time optimization). Apple clang compiler has some bug somewhere in LTO. I'll update the v3.6.2 release with this binary.

nullifiedtoast commented 10 months ago

I am glad you were able to figure out the issue. Thank you again for the fast responses to get it fixed.

nullifiedtoast commented 10 months ago

Only thing I noticed about the version you just sent me was that my miners were not able to connect to the pool with it.

SChernykh commented 10 months ago

Check your firewall settings (path to the binary, port numbers). You probably need to approve the new binary.

nullifiedtoast commented 10 months ago

I needed to move the binary into the folder with the rest of p2pool files. That was my mistake all is working correctly.