SChernykh / p2pool

Decentralized pool for Monero mining
GNU General Public License v3.0
1.03k stars 123 forks source link

Block not accepted #289

Closed bzhubs closed 7 months ago

bzhubs commented 7 months ago

NOTICE 2023-11-11 14:26:00.1210 SideChain add_external_block: block xxxxxxxxxxxxxxxxxxxxxxxxxxxx has enough PoW for Monero height 3015630, submitting it NOTICE 2023-11-11 14:26:00.1211 SideChain add_block: height = 6641356, id =xxxxxxxxxxxxxxxxxxxxxxxxxxxxx, mainchain height = 3015630, verified = 0 NOTICE 2023-11-11 14:26:00.1213 P2Pool submit_block: height = 3015801, external blob (1809 bytes) WARNING 2023-11-11 14:26:00.1268 P2Pool submit_block (external blob): daemon returned error: Block not accepted

Server configuration: 4-core CPU, 8G memory, 250G ssd, p2pool and monerod running on the same server

./monerod --detach --data-dir=/data/block --zmq-pub tcp://127.0.0.1:18083 --out-peers 32 --in-peers 64 --add-priority-node=nodes.hashvault.pro:18080 --add-priority-node=p2pmd.xmrvsbeast.com:18080 --disable-dns-checkpoints --enable-dns-blocklist --rpc-bind-ip=0.0.0.0 --confirm-external-bind --limit-rate-down=81920

./p2pool --host 127.0.0.1 --wallet xxxxxxxxxx

Hello, there are a lot of warnings like this in my p2pool. Is this related to server performance or network quality?

SChernykh commented 7 months ago

This is normal during the initial sync, because it tries to submit blocks that were already submitted before. In general, external blob blocks can be rejected by your node because they can contain transactions unknown by your node.

bzhubs commented 7 months ago

It's not during the synchronization period. It has been running normally for more than a month. There are many such situations every day. I don't know if it is because of server performance problems or other problems.

SChernykh commented 7 months ago

This is not a critical error. Your P2Pool node tries to submit a Monero block which was found by someone else. This block can have transactions unknown to your Monero node, so it can reject it. I would check how well is your Monero node connected, if incoming connections are open, if there are any other errors in monerod log (other than "transaction not found in pool").

bzhubs commented 7 months ago

No incoming connection is opened, bu monerod log: 2023-11-14 23:38:16.737 [RPC1] ERROR cn src/cryptonote_core/cryptonote_core.cpp:1538 Transaction not found in pool 2023-11-15 01:22:29.448 [RPC1] ERROR cn src/cryptonote_core/cryptonote_core.cpp:1538 Transaction not found in pool 2023-11-15 04:17:40.939 [RPC0] ERROR cn src/cryptonote_core/cryptonote_core.cpp:1538 Transaction not found in pool 2023-11-15 04:45:28.756 [RPC0] ERROR cn src/cryptonote_core/cryptonote_core.cpp:1538 Transaction not found in pool 2023-11-15 04:59:27.935 [RPC1] ERROR cn src/cryptonote_core/cryptonote_core.cpp:1538 Transaction not found in pool 2023-11-15 05:06:50.174 [RPC0] ERROR cn src/cryptonote_core/cryptonote_core.cpp:1538 Transaction not found in pool 2023-11-15 06:12:33.777 [RPC1] ERROR cn src/cryptonote_core/cryptonote_core.cpp:1538 Transaction not found in pool 2023-11-15 07:15:23.895 [RPC1] ERROR cn src/cryptonote_core/cryptonote_core.cpp:1538 Transaction not found in pool 2023-11-15 07:45:38.102 [RPC0] ERROR cn src/cryptonote_core/cryptonote_core.cpp:1538 Transaction not found in pool 2023-11-15 08:25:44.412 [RPC0] ERROR cn src/cryptonote_core/cryptonote_core.cpp:1538 Transaction not found in pool 2023-11-15 10:47:41.804 [RPC1] ERROR cn src/cryptonote_core/cryptonote_core.cpp:1538 Transaction not found in pool 2023-11-15 11:20:15.772 [RPC1] ERROR cn src/cryptonote_core/cryptonote_core.cpp:1538 Transaction not found in pool 2023-11-15 11:26:55.100 [RPC0] ERROR cn src/cryptonote_core/cryptonote_core.cpp:1538 Transaction not found in pool

SChernykh commented 7 months ago

This is normal for monerod running p2pool. I have this on my node too, just not in the same quantity (I have 1-2 errors/day). You can try to increase outgoing connection count in monerod. Your Monero node isn't fast enough to receive new transactions sometimes.

bzhubs commented 7 months ago

Can you tell me the specific parameters? I do not understand

SChernykh commented 7 months ago

It's --out-peers parameter in monerod command line. It's described in https://p2pool.io/#help You can try to have more than 32 outgoing connections.

bzhubs commented 7 months ago

./monerod --detach --data-dir=/data/block --zmq-pub tcp://127.0.0.1:18083 --out-peers 32 --in-peers 64 --add-priority-node=nodes.hashvault.pro:18080 --add-priority-node=p2pmd.xmrvsbeast.com:18080 --disable-dns-checkpoints --enable-dns-blocklist --rpc-bind-ip=0.0.0.0 --confirm-external-bind --limit-rate-down=81920

What value do I need to change to? And what ports need to be opened?

SChernykh commented 7 months ago

You can try --out-peers 64, and you need to open port 18080 (monerod) and 37889 (p2pool) for incoming connections.

bzhubs commented 7 months ago

Ok,Thank you.

bzhubs commented 7 months ago

Can improving server performance of monerod p2pool increase output?

SChernykh commented 7 months ago

No. If P2Pool doesn't print any other warnings/errors about your Monero node, it's fine.

bzhubs commented 7 months ago

2023-11-13 22:51:40.656 [RPC1] ERROR cn src/cryptonote_core/cryptonote_core.cpp:1538 Transaction not found in pool 2023-11-13 23:41:19.893 [RPC0] ERROR cn src/cryptonote_core/cryptonote_core.cpp:1538 Transaction not found in pool 2023-11-14 00:45:52.741 [RPC0] ERROR cn src/cryptonote_core/cryptonote_core.cpp:1538 Transaction not found in pool 2023-11-14 01:46:01.678 [RPC1] ERROR cn src/cryptonote_core/cryptonote_core.cpp:1538 Transaction not found in pool 2023-11-14 04:17:42.088 [RPC0] ERROR cn src/cryptonote_core/cryptonote_core.cpp:1538 Transaction not found in pool 2023-11-14 05:18:07.480 [RPC0] ERROR cn src/cryptonote_core/cryptonote_core.cpp:1538 Transaction not found in pool 2023-11-14 07:44:34.903 [RPC1] ERROR cn src/cryptonote_core/cryptonote_core.cpp:1538 Transaction not found in pool 2023-11-14 07:45:18.444 [RPC0] ERROR cn src/cryptonote_core/cryptonote_core.cpp:1538 Transaction not found in pool 2023-11-14 08:49:16.728 [RPC1] ERROR cn src/cryptonote_core/cryptonote_core.cpp:1538 Transaction not found in pool 2023-11-14 11:50:21.413 [RPC1] ERROR cn src/cryptonote_core/cryptonote_core.cpp:1538 Transaction not found in pool 2023-11-14 11:58:00.327 [RPC1] ERROR cn src/cryptonote_core/cryptonote_core.cpp:1538 Transaction not found in pool 2023-11-14 12:58:03.612 [RPC1] ERROR cn src/cryptonote_core/cryptonote_core.cpp:1538 Transaction not found in pool 2023-11-14 13:24:25.685 [RPC0] ERROR cn src/cryptonote_core/cryptonote_core.cpp:1538 Transaction not found in pool 2023-11-14 14:36:26.501 [RPC0] ERROR cn src/cryptonote_core/cryptonote_core.cpp:1538 Transaction not found in pool 2023-11-14 14:47:16.176 [P2P8] INFO global src/blockchain_db/lmdb/db_lmdb.cpp:692 [batch] DB resize needed 2023-11-14 14:47:16.511 [P2P8] INFO global src/blockchain_db/lmdb/db_lmdb.cpp:612 LMDB Mapsize increased. Old: 192127MiB, New: 193151MiB 2023-11-14 15:27:54.279 [RPC1] ERROR cn src/cryptonote_core/cryptonote_core.cpp:1538 Transaction not found in pool 2023-11-14 16:14:33.033 [RPC1] ERROR cn src/cryptonote_core/cryptonote_core.cpp:1538 Transaction not found in pool 2023-11-14 18:18:21.221 [RPC1] ERROR cn src/cryptonote_core/cryptonote_core.cpp:1538 Transaction not found in pool 2023-11-14 19:24:05.011 [RPC0] ERROR cn src/cryptonote_core/cryptonote_core.cpp:1538 Transaction not found in pool 2023-11-14 20:24:55.584 [RPC0] ERROR cn src/cryptonote_core/cryptonote_core.cpp:1538 Transaction not found in pool 2023-11-14 22:18:44.016 [RPC0] ERROR cn src/cryptonote_core/cryptonote_core.cpp:1538 Transaction not found in pool 2023-11-14 22:35:13.539 [P2P2] INFO global src/cryptonote_core/blockchain.cpp:2137 ----- BLOCK ADDED AS ALTERNATIVE ON HEIGHT 3018187 2023-11-14 22:35:13.539 [P2P2] INFO global src/cryptonote_core/blockchain.cpp:2137 id: <96fa400c38ce4ee738693d94d1bcbd5449ceb4c361db2> 2023-11-14 22:35:13.539 [P2P2] INFO global src/cryptonote_core/blockchain.cpp:2137 PoW: <660a8d754f40d7cc291d495d3a291bd8fb0000000000> 2023-11-14 22:35:13.539 [P2P2] INFO global src/cryptonote_core/blockchain.cpp:2137 difficulty: 269840587092 2023-11-14 22:36:18.823 [P2P3] INFO global src/cryptonote_core/blockchain.cpp:2126 ###### REORGANIZE on height: 3018187 of 3018187 with cum_difficulty 318303102833132465 2023-11-14 22:36:18.823 [P2P3] INFO global src/cryptonote_core/blockchain.cpp:2126 alternative blockchain size: 2 with cum_difficulty 318303372469829624 2023-11-14 22:36:21.051 [P2P3] INFO global src/cryptonote_core/blockchain.cpp:2137 ----- BLOCK ADDED AS ALTERNATIVE ON HEIGHT 3018187 2023-11-14 22:36:21.051 [P2P3] INFO global src/cryptonote_core/blockchain.cpp:2137 id: 2023-11-14 22:36:21.051 [P2P3] INFO global src/cryptonote_core/blockchain.cpp:2137 PoW: <4dc0f6d9641116fa84386126342cbec5e20300000000> 2023-11-14 22:36:21.051 [P2P3] INFO global src/cryptonote_core/blockchain.cpp:2137 difficulty: 269840587092 2023-11-14 22:36:25.305 [P2P3] INFO global src/cryptonote_core/blockchain.cpp:1286 REORGANIZE SUCCESS! on height: 3018187, new blockchain size: 3018189 2023-11-14 23:30:41.628 [RPC1] ERROR cn src/cryptonote_core/cryptonote_core.cpp:1538 Transaction not found in pool 2023-11-14 23:38:16.737 [RPC1] ERROR cn src/cryptonote_core/cryptonote_core.cpp:1538 Transaction not found in pool 2023-11-15 01:22:29.448 [RPC1] ERROR cn src/cryptonote_core/cryptonote_core.cpp:1538 Transaction not found in pool 2023-11-15 04:17:40.939 [RPC0] ERROR cn src/cryptonote_core/cryptonote_core.cpp:1538 Transaction not found in pool 2023-11-15 04:45:28.756 [RPC0] ERROR cn src/cryptonote_core/cryptonote_core.cpp:1538 Transaction not found in pool 2023-11-15 04:59:27.935 [RPC1] ERROR cn src/cryptonote_core/cryptonote_core.cpp:1538 Transaction not found in pool 2023-11-15 05:06:50.174 [RPC0] ERROR cn src/cryptonote_core/cryptonote_core.cpp:1538 Transaction not found in pool 2023-11-15 06:12:33.777 [RPC1] ERROR cn src/cryptonote_core/cryptonote_core.cpp:1538 Transaction not found in pool 2023-11-15 07:15:23.895 [RPC1] ERROR cn src/cryptonote_core/cryptonote_core.cpp:1538 Transaction not found in pool 2023-11-15 07:45:38.102 [RPC0] ERROR cn src/cryptonote_core/cryptonote_core.cpp:1538 Transaction not found in pool 2023-11-15 08:25:44.412 [RPC0] ERROR cn src/cryptonote_core/cryptonote_core.cpp:1538 Transaction not found in pool 2023-11-15 10:47:41.804 [RPC1] ERROR cn src/cryptonote_core/cryptonote_core.cpp:1538 Transaction not found in pool 2023-11-15 11:20:15.772 [RPC1] ERROR cn src/cryptonote_core/cryptonote_core.cpp:1538 Transaction not found in pool 2023-11-15 11:26:55.100 [RPC0] ERROR cn src/cryptonote_core/cryptonote_core.cpp:1538 Transaction not found in pool

The main reason is that there is a lot of this kind of information, and the computing power is unstable. Looking at p2pool.observer, the computing power is 1M for a while, 400K for a while, 600K for a while... I don’t know the reason.

bzhubs commented 7 months ago

Will your computing power be unstable?

SChernykh commented 7 months ago

Looking at p2pool.observer, the computing power is 1M for a while, 400K for a while, 600K for a while... I don’t know the reason.

The observer shows hashrate estimation, based on the shares you have in PPLNS window. It's affected by luck a lot. You should check "Day Hashrate" there, it will be more stable.

bzhubs commented 7 months ago

Ok,Thank you.

bzhubs commented 7 months ago

Let me ask another question, is this kind of log normal? Thank you. p2pool log:

WARNING 2023-11-15 12:34:10.6839 P2PServer peer 15.235.54.153:59604 banned for 600 seconds WARNING 2023-11-15 12:37:52.7877 P2PServer peer 75.148.112.205:63636 banned for 600 seconds WARNING 2023-11-15 12:38:31.7082 P2PServer peer 83.18.155.22:26530 banned for 600 seconds WARNING 2023-11-15 12:48:34.2282 P2PServer peer 83.18.155.22:37466 banned for 600 seconds WARNING 2023-11-15 12:58:36.6657 P2PServer peer 83.18.155.22:11132 banned for 600 seconds WARNING 2023-11-15 13:08:39.2441 P2PServer peer 83.18.155.22:59281 banned for 600 seconds WARNING 2023-11-15 13:18:41.7964 P2PServer peer 83.18.155.22:33933 banned for 600 seconds WARNING 2023-11-15 13:28:44.2458 P2PServer peer 83.18.155.22:33898 banned for 600 seconds WARNING 2023-11-15 13:35:56.3258 P2PServer peer 15.235.54.153:51364 banned for 600 seconds WARNING 2023-11-15 13:38:46.7007 P2PServer peer 83.18.155.22:4356 banned for 600 seconds WARNING 2023-11-15 13:48:49.0339 P2PServer peer 83.18.155.22:55368 banned for 600 seconds WARNING 2023-11-15 13:50:56.6909 P2PServer peer 93.221.2.145:40970 banned for 600 seconds WARNING 2023-11-15 13:54:32.7756 P2PServer peer 75.148.112.205:2795 banned for 600 seconds WARNING 2023-11-15 13:58:51.4143 P2PServer peer 83.18.155.22:48472 banned for 600 seconds WARNING 2023-11-15 14:08:53.8548 P2PServer peer 83.18.155.22:43269 banned for 600 seconds WARNING 2023-11-15 14:18:56.2092 P2PServer peer 83.18.155.22:21441 banned for 600 seconds WARNING 2023-11-15 14:28:58.7070 P2PServer peer 83.18.155.22:21833 banned for 600 seconds WARNING 2023-11-15 14:39:01.1302 P2PServer peer 83.18.155.22:21286 banned for 600 seconds WARNING 2023-11-15 14:49:03.5697 P2PServer peer 83.18.155.22:51351 banned for 600 seconds WARNING 2023-11-15 14:59:05.9967 P2PServer peer 83.18.155.22:44120 banned for 600 seconds WARNING 2023-11-15 15:03:35.4253 P2Pool get_miner_data RPC response is invalid, skipping it WARNING 2023-11-15 15:07:25.5944 P2PServer peer 149.200.76.44:57602 banned for 600 seconds WARNING 2023-11-15 15:09:08.4152 P2PServer peer 83.18.155.22:14809 banned for 600 seconds WARNING 2023-11-15 15:11:02.5516 P2Pool submit_block (external blob): daemon returned error: Block not accepted WARNING 2023-11-15 15:19:10.8799 P2PServer peer 83.18.155.22:47234 banned for 600 seconds WARNING 2023-11-15 15:19:37.5166 P2PServer peer 80.56.38.250:60210 banned for 600 seconds

SChernykh commented 7 months ago

Banned peers are normal, but get_miner_data RPC response is invalid, skipping it is not good. You should check what was in monerod log at that time (2023-11-15 15:03:35)

bzhubs commented 7 months ago

WARNING 2023-11-15 15:03:35.4253 P2Pool get_miner_data RPC response is invalid, skipping it

At this point in time I am restarting monerod, this should be the reason