search

SCons / scons

SCons - a software construction tool
http://scons.org
MIT License
2.1k stars 315 forks source link

Support for Windows MSI archives (WiX) is broken #2727

Open bdbaddog opened 6 years ago

bdbaddog commented 6 years ago

This issue was originally created at: 2011-01-11 09:05:03. This issue was reported by: dirkbaechle. dirkbaechle said at 2011-01-11 09:05:04

Hi,

based on the user reports/questions in

http://scons.tigris.org/ds/viewMessage.do?dsForumId=1272&dsMessageId=2435080

I started to investigate the problem a little bit. From what I see in the sources for Tool/wix.py and Tool/packaging/msi.py it simply cannot work at the moment:

1.) In lines 492-495 of msi.py we have

# this builder is the entry-point for .wxs file compiler.
wxs_builder = Builder(
action         = Action( build_wxsfile, string_wxsfile ),
ensure_suffix  = '.wxs' )

where the last line looks wrong to me. This should read something like suffix = '.wxs', ensure_suffix = 1 )

instead.

2.) When fixing 1), I get the next error in gen_dos_short_file_name() at line 117 of msi.py. The expression

fname[:8-len(str(num))]

becomes a list, which doesn't have an upper() method.

Best regards,

Dirk

dirkbaechle said at 2011-01-11 09:07:55

Created an attachment (id=827) Very simple testcase

dirkbaechle attached wix.zip at 2011-01-11 09:07:55.

Very simple testcase

ajf58 commented 6 years ago

This is still an issue in SCons 3.0.1.