search

SD2E / opil

The Open Protocol Interface Language (OPIL) is intended as a standard language for protocol interfaces
5 stars 1 forks source link

ProtocolInterface missing sample sets #106

Closed jakebeal closed 3 years ago

jakebeal commented 3 years ago

ProtocolInterface is missing the hasSampleSet property, which should be cardinality 0..*

bbartley commented 3 years ago

Is the property synonymous with allowedSamples in the powerpoint? Which property name is preferable?

Also the powerpoint diagrams show one Toplevel class (ProtocolInterface) with another TopLevel as its child (CombinatorialDerivation). This seems like an error in the spec. From a more practical standpoint, it doesn't cause any obvious bugs using pySBOL for file IO, but there may be more subtle bugs lurking.

jakebeal commented 3 years ago

I think allowedSamples would be better than hasSampleSet

And yes, the CDs should be references and not children.