search

SD2E / opil

The Open Protocol Interface Language (OPIL) is intended as a standard language for protocol interfaces
5 stars 1 forks source link

Property names are confusing and inconsistent #177

Open bjkeller opened 3 years ago

bjkeller commented 3 years ago

The naming of properties of classes is confusing.

Specifically:

  1. property names that have the prefix has_ that makes them look like a predicate. ex: ExperimentalRequest.has_parameter_value.
  2. property names in the same class that don't have has_ as a prefix (I prefer this, but what's the convention?): ExperimentalRequest.measurement
  3. property names that don't have anything to do with the cardinality: ExperimentalRequest.measurement
bbartley commented 3 years ago

Hi @bjkeller I agree with all the points you make here. It's relatively easy to change the names of attributes to follow a more consistent pattern, but the question for everybody is when is the right time to make these changes? Mainly, I'm concerned about breaking @tramyn 's IntentParser prior to the program meeting.