search

SD2E / opil

The Open Protocol Interface Language (OPIL) is intended as a standard language for protocol interfaces
5 stars 1 forks source link

`Parameters` need a `unit` property #8

Open bbartley opened 3 years ago

bbartley commented 3 years ago

Some Protocol Parameters will need to specify a unit. It is not possible to use sbol.Measure for this, because Measures require both a unit and a value

rmarkelo commented 3 years ago

It appears that some parameters may only be given in particular units and we need to be able to verify this. Is this the idea?

bbartley commented 3 years ago

Yep, that's the idea. For example, if there were a Parameter representing volume, we want to tell the user that the volume must be specified in microliters, as opposed to, say liters. I don't think we need a new opil term for units though. I believe the right predicate to use here is simply om:hasUnit

rmarkelo commented 3 years ago

We could do that, although the Parameter class is not included in the domain specified for hasUnit in the Units of Measure ontology. That can cause problems only if we do OWL reasoning, which we have no plans to do right now.

jakebeal commented 3 years ago

Related to #135

rmarkelo commented 3 years ago

Hi Jake,

Just so I can keep abreast of what you're up to, what is PAML? A Google search turns up Phylogenetic Analysis by Maximum Likelihood, but I'm guessing you mean something else.

Thanks,

Rich

Richard Markeloff, Ph.D. Senior Scientist Raytheon BBN Technologies Office: 703-284-1221 Mobile: 571-485-0189 Email: richard.markeloff@raytheon.com

From: Jacob Beal notifications@github.com Sent: Thursday, February 11, 2021 5:49 AM To: SD2E/opil opil@noreply.github.com Cc: rmarkelo richard.markeloff@rtx.com; Comment comment@noreply.github.com Subject: [External] Re: [SD2E/opil] Parameters need a unit property (#8)

Related to #135https://urldefense.com/v3/__https://github.com/SD2E/opil/issues/135__;!!MvWE!XUllapWH_PvnRWGl_UUVgflxS2u59mhYBsiDQjeKevtD8r2L1Kag7uwRrZPdL_rS9YjL$

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https://github.com/SD2E/opil/issues/8*issuecomment-777358067__;Iw!!MvWE!XUllapWH_PvnRWGl_UUVgflxS2u59mhYBsiDQjeKevtD8r2L1Kag7uwRrZPdL9qTeny_$, or unsubscribehttps://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AQTI4O66VG2ILTLFXZ3ZQFDS6OY3NANCNFSM4RYZKSBA__;!!MvWE!XUllapWH_PvnRWGl_UUVgflxS2u59mhYBsiDQjeKevtD8r2L1Kag7uwRrZPdLxRCR-3f$.

jakebeal commented 3 years ago

https://github.com/SD2E/paml