In the current state, we provide the desired SAT solution strategy by a list that is referred to as the order. I think that it is intuitive to assume that the things that come first in the list are set first (and we also create the default variable order in this way).
However, the SAT4J API uses activity instead of the order of the variables and the variables with the HIGHEST activity are set FIRST. So, in the current state, the variables that we provide on the last positions of the list are set first.
We can address this issue by either changing the documentation or the code. I find it intuitive to directly provide the solving order by a list of variables where the first variable type is set first and so forth, so I suggest to alter the code as proposed by this PR.
In the current state, we provide the desired SAT solution strategy by a list that is referred to as the order. I think that it is intuitive to assume that the things that come first in the list are set first (and we also create the default variable order in this way).
However, the SAT4J API uses activity instead of the order of the variables and the variables with the HIGHEST activity are set FIRST. So, in the current state, the variables that we provide on the last positions of the list are set first.
We can address this issue by either changing the documentation or the code. I find it intuitive to directly provide the solving order by a list of variables where the first variable type is set first and so forth, so I suggest to alter the code as proposed by this PR.