search

SDARG / opt4j

Modular Java framework for meta-heuristic optimization
https://sdarg.github.io/opt4j/
MIT License
32 stars 17 forks source link

Discuss and fix PMD / coding style #39

Open michaelhglass opened 6 years ago

michaelhglass commented 6 years ago

Since the codacy integration, we should discuss and agree upon PMDs/coding style we want to respect and then fix this in the codacy configuration. Since those things can also be changed directly in codacy, I assume we will see inconsistent markings. Thus, all those decisions should be reflected and fixed in the project - .codacy.yml may be a good starting point.

FedorSmirnov89 commented 6 years ago

I think the first step here would be to gather all the cases that we want to discuss (or the cases where we disagree with the current codacy code style configuration).

michaelhglass commented 6 years ago

Codacy by default takes configuration files for checkstyle, PMD etc. see https://support.codacy.com/hc/en-us/articles/207994335-Code-Patterns @felixreimann proposed one checkstyle in the checkstyle branch. I think we should check which standard configurations are out there, create a branch and see what kind of issues they raise and how reasonable/compatible this is to our current style and then go from there. Anyone willing?

FedorSmirnov89 commented 6 years ago

I can do the branch creation and search for the code styles. Then all of us should have a look at it and discuss the whole thing (ideally in a telco).

FedorSmirnov89 commented 6 years ago

I will create one branch for each code style and add them to my Codacy perspective so that each of us can have a look at the kind of issues that the style results in