search

SDCA-tool / sdca-website

Website for the Shared Digital Carbon Architecture tool
GNU General Public License v3.0
0 stars 0 forks source link

Feedback on map layers #13

Open mem48 opened 2 years ago

mem48 commented 2 years ago

General comments on the map layers. Low priority to be fixed if you have the time

mvl22 commented 2 years ago

Thanks - this is a very helpful list. Most of these are known about but it's helpful to have explicit suggestions for some of the ones I wasn't sure about.

The planning applications layer isn't fully broken as such, by the way - it's slow, and is also rate-limited. If you zoom right in and then enable it, it will show. This will improve when I configure it a bit for large/medium applications only.

mem48 commented 2 years ago

The geology layers. The BGS website used a more complex set of categories that we have included in our site. SO this is more for inspiration than to copy exactly.

Lookup table for the possible values are:

Bedrock - https://github.com/SDCA-tool/sdca-data/blob/main/package_files/bedrock.csv Superficial - https://github.com/SDCA-tool/sdca-data/blob/main/package_files/superficial.csv

mvl22 commented 2 years ago

Some colours here: https://github.com/creds2/CarbonCalculator/blob/master/www/js/layer_control.js which result in: https://www.carbon.place/

which need to be transcribed to: https://github.com/SDCA-tool/sdca-data/tree/main/styles

mvl22 commented 2 years ago

Flood zones style light blue for type 2 and dark blue for type 3

Added in https://github.com/SDCA-tool/sdca-data/commit/90d1b137eb692554522ac03daf09c3540195b304

mvl22 commented 2 years ago

Listed buildings - Style based on grade

Added in https://github.com/SDCA-tool/sdca-data/commit/ba3fdc1eefbc03dc5098a2c5d9d14a4f68d474cd

mvl22 commented 2 years ago

Bedrock geology - style based on type (see https://mapapps.bgs.ac.uk/geologyofbritain/home.html for example)

Added in https://github.com/SDCA-tool/sdca-data/commit/020de1c2489b7cb74dcfdbdbedee4cc5b943edfc

mem48 commented 2 years ago

Traffic layer still seems broken but marked as done

mem48 commented 2 years ago
mvl22 commented 2 years ago

Traffic layer still seems broken but marked as done

I've fixed the broken popups. The layer has always been working I thought, though it is limited to 1,000 lines per map view, as it is API-based with a large amount of data. This could be changed to be tiles-based in future.

mvl22 commented 2 years ago

Planning applications - Broken

Now limited to large/medium applications, which makes this more useful. Random house changes, garages etc., no longer shown.

Performance issue (due to rate limiting) resolution pending.

mem48 commented 2 years ago

I've fixed the broken popups. The layer has always been working I thought, though it is limited to 1,000 lines per map view, as it is API-based with a large amount of data. This could be changed to be tiles-based in future.

Now working, perhaps this was due to the same problem with the missing lines when drawing

mvl22 commented 2 years ago

Greenbelt/National park. AONB, etc - coloured fill (option to toggle to grey scale)

Added in https://github.com/SDCA-tool/sdca-data/commit/134a2f739b8de3aad577a867d36085e107b56ed7.

I've not bothered with option to toggle to grayscale, as the layers are semi-transparent anyway, and the GDS guidelines/components don't really have support for nested checkboxes.

mvl22 commented 2 years ago

Local Authority boundaries - grey polygons rather than coloured lines to match other boundaries

@mem48 Wasn't sure what you mean here. They are already grey polygons, but the other boundary layers are coloured lines. Can you clarify?

mem48 commented 2 years ago

The boundaries should be coloured lines, not grey polygons. So change the LAs to match wards/parish etc. See www.carbon.place for example.

The reason is users often want to overlay administrative boundaries onto other data. So grey polygons get in the way of the data below.

mvl22 commented 2 years ago

The boundaries should be coloured lines, not grey polygons.

Thanks. Done in: https://github.com/SDCA-tool/sdca-data/commit/7058bf147fab3ff548082a5e2256cf6fd3779789.

mvl22 commented 2 years ago

LSOA boundaries, multiple visualisation styles to match www.carbon.place

This is now supported, and was way more work to add sublayer support than I expected.

There are some bugs, i.e. initial sublayer URL loading state, and opacity support, but I will try to fix these up in due course. However, this is now way improved over the situation before where the sublayers could not even be selected.

Screenshot 2022-08-08 at 15 42 51

Screenshot 2022-08-08 at 15 44 44

mvl22 commented 2 years ago

Superficial geology

Are there any colour key sets for this anywhere?

mem48 commented 2 years ago

(see https://mapapps.bgs.ac.uk/geologyofbritain/home.html for example) But only as a rough guide, any set of colours will do for now

mem48 commented 2 years ago

Well done on the LSOA layer. Is it possible to add some transparency so the basemap is visible?

mem48 commented 2 years ago

Also the Average EPC score, Average floor area, and Low energy lights layers don't use the special colour schemes thy have in www.carbon.place

mem48 commented 2 years ago

Also now we have the LSOA layers done is it easy to add the NTEM zones in transport data in the same way? A simple colour gradient for each variable would be fine. Summary of the values below:

  Zone_Code             cycle            drive          passenger          walk            rail               bus       
 Length:7700        Min.   :   4.0   Min.   :   782   Min.   :  574   Min.   :  561   Min.   :     0.0   Min.   :  111  
 Class :character   1st Qu.: 149.0   1st Qu.:  4751   1st Qu.: 2710   1st Qu.: 2525   1st Qu.:    32.0   1st Qu.:  944  
 Mode  :character   Median : 230.0   Median :  6388   Median : 3640   Median : 3339   Median :    61.0   Median : 1340  
                    Mean   : 283.9   Mean   :  7286   Mean   : 4191   Mean   : 3934   Mean   :   298.4   Mean   : 1814  
                    3rd Qu.: 335.0   3rd Qu.:  8635   3rd Qu.: 4925   3rd Qu.: 4522   3rd Qu.:   173.0   3rd Qu.: 2074  
                    Max.   :9832.0   Max.   :109666   Max.   :60552   Max.   :67842   Max.   :138212.0   Max.   :51296
mvl22 commented 2 years ago

Well done on the LSOA layer. Is it possible to add some transparency so the basemap is visible?

As I noted:

There are some bugs, i.e. initial sublayer URL loading state, and opacity support, but I will try to fix these up in due course.

mvl22 commented 2 years ago

Superficial geology

Now in place.

Screenshot 2022-08-10 at 17 26 24

mvl22 commented 2 years ago

Is it possible to add some transparency so the basemap is visible?

Now restored.

Screenshot 2022-08-10 at 19 11 04

mvl22 commented 2 years ago

Planning applications - Broken

Performance issue (due to rate limiting) resolution pending.

There is no longer a rate limit in place.

However, the API call can still be a bit slow to give a response. I have added an alpha note in the UI so that this is clear to the user. Performance work upstream is ongoing.

mvl22 commented 2 years ago