SDCA-tool / sdca-website

Website for the Shared Digital Carbon Architecture tool
GNU General Public License v3.0
0 stars 0 forks source link

Warning messages not appearing on the map #9

Closed mem48 closed 2 years ago

mem48 commented 2 years ago

The package is still returning a test error message to be shown on the map. A point in London.

But it doesn't show on the map. I would like to add more to this feature, but not point until they appear on the map.

mem48 commented 2 years ago

I've now pushed an update to the package so real messages are returned. The package will highlight any locations that the intervention crosses water (except if the infrastructure is a bridge or tunnel)

mvl22 commented 2 years ago

There is a related problem that if there are no items, it does not return valid GeoJSON but instead an empty plain array:

[]

Siequnu commented 2 years ago

I'm seeing these now Screenshot 2022-02-18 at 19 34 04

mvl22 commented 2 years ago

There is a related problem that if there are no items, it does not return valid GeoJSON but instead an empty plain array

This aspect was fixed by Malcolm in https://github.com/SDCA-tool/sdca-package/commit/68d76794fb26ad292eb1204eb2e8318a09632f92.

mvl22 commented 2 years ago

I'm seeing these now

Yes, I am starting to see these now.

However, it's not very obvious to the user that the yellow markers have been added. I think we need a warning paragraph, as per the overwriting warning style, in the Scheme results > Summary box, probably above the main red/green box.

PS I will change the markers from yellow to a warning marker.

mem48 commented 2 years ago

I'm not seeing the markers, is this feature live on the website yet?

image

mem48 commented 2 years ago

Using Firefox 97 on WIndows 10 64 Bit

mvl22 commented 2 years ago

Malcolm, can you please shift-refresh or load in incognito to ensure you're definitely catching the latest assets release.

mem48 commented 2 years ago

In private mode on firefox

image

mem48 commented 2 years ago

Incognito mode in chome

image

mem48 commented 2 years ago

I tried different interventions hence the different carbon footprints

mvl22 commented 2 years ago

@mem48, can you confirm this is working for you now? I am seeing them.

E.g. that south lincs error problem with the desire_lines - those are showing markers: Screenshot 2022-02-18 at 17 27 59

mvl22 commented 2 years ago

I've now got a reproduce case on the problem.

mvl22 commented 2 years ago

This is now fixed.

@mem48 Do confirm if you can, but it's consistently loading properly now, and I can see why.

mem48 commented 2 years ago

Yes now working.

mvl22 commented 2 years ago

Now also fixed the bug whereby the warnings/errors layer was not cleared if resetting.