Some features in skills plugin need to be active even if the bot isn't started

SDClowen / RSBot

A Silkroad Online Open Source Bot

GNU Affero General Public License v3.0

130 stars 111 forks source link

Some features in skills plugin need to be active even if the bot isn't started #172

Open Ahmed0425 opened 2 years ago

Ahmed0425 commented 2 years ago

I think features like auto attacking/buffing and auto resurrection is better to active even with bot disabled .. should be easier for lazy hand-grinders .. also I believe it's known that continues fast clicking on down bar numbers can hurt your hand and your fingers in the long term also imagine a bot party in the forgotten world with one hand controlled player with others tracing him, can be useful in such case

ngoedde commented 2 years ago

I realy like this idea. There are two ways to implement:

A second botloop running if the bot is stopped
Re-use the current one but ignore the active state of the bot. The botbase then needs to decide what to do.

@SDClowen That's something I can check if you want.

SDClowen commented 2 years ago

If I understand it correctly, If the bot is not started, there is no point in having those skills active and it will only cause confusion. Okay, I understand you, in this completely forgotten world and similar areas, players will use each other while in trace mode, but if issue #2 is completed, your opinion will not be needed.