Closed jacksono closed 1 year ago
Hi @jacksono ! Thanks a lot for the PR. I will provide my comments/questions below:
I think, quadrant page info card seems like the width we should have, at most. You can think like at most as the width of quadrant page info card.
The centerized title can also be in the quadrant pages
The mobile appearance is really good. At least we don't have any issue with the overlaps. I have a couple suggestions for it:
I think that's pretty much it. Really appreciated work @jacksono Thanks a lot!
Hi @OzgeOzkaya I have made most of the changes you suggested in the comments. The ones that we will need to align on one are:
We can have a call on Monday 19th September at 4:15pm (GMT + 3) to go over these missing parts.
Thanks again @jacksono ! After our talk, I listed the fixes as below:
Hi @OzgeOzkaya I have made the fixes we discussed yesterday. Kindly take another look. For the quadrants on the mobile view I went with only adding color to the text since there was no direct and clean way to have the outer circle appear.
Dear @jacksono thank you for your work. I just realized that the gap between the filtering section and the top of the page still remains. Also now this issue appears in the desktop view as well. If you could kindly check and fix this issue, I will merge the PR. Thanks a again!
still remains. Also now this issue appears in the desktop view as well. If you could kindly check and fix this issue, I will merge the PR. Thanks a again!
@OzgeOzkaya I may have misunderstood the requirement yesterday.
It is currently like this?
Do you mean that the gap should be removed so that it looks like this:
Good to go! Thanks a lot @jacksono !
The radar should be as in the same height as the information car. If we consider the page is divided into two and the left side of the divided part allocates 60% of the page while the right side allocates 40%.
The radar should be on the left side and the information card should be on the right side.
There should be a gap between the radar and the information card.
There should be a gap between the navbar and the radar; information card and the right-side screen limitation. Responsiveness of any type of screen and mobile should also be considered
Screenshots