search

SDGforskning / find-sdg-research

Website and search interface for Find SDG Research
https://baerekraftsforskning.no
Creative Commons Attribution 4.0 International
1 stars 5 forks source link

Duplicate ids in all WoS searchstring pages #116

Open tarjelavik opened 1 year ago

tarjelavik commented 1 year ago

Checking for errors reveals only one error, one that has been created by the footnotes in the searchstring pages.

A reference in the text has double a tag: <a id="gsdrc">([Carter et al. 2019](#f9))</a>. Since the markdown parser creates a link from the MB []() pattern, the outer a messes stuff up.

In the footnote we see this:

<a id="f9"></a> Carter, Roelen, Enfield & Avis (2019) Types of social protection. 
Governance and Social Development Resource Centre.
 (https://gsdrc.org/topic-guides/social-protection/types-of-social-protection/) 
[Accessed May 2022].[↩](#gsdrc)

Since the id "gsdrc" is used more than once, the backlink do not know what to target. the id can only ever be used once per page.

Unsure of why it looks they way i does. Are these markdown files an output from somewhere? @Caroline-A?

Solution:

Caroline-A commented 1 year ago

Hey sorry I don't fully understand the bug, the footnote and internal linking looks/works ok when I look at the webpage? https://baerekraftsforskning.no/en/sokestreng/wos/actions/SDG01_query_action_WoS#gsdrc

Unsure of why it looks they way i does. Are these markdown files an output from somewhere? @Caroline-A?

The markdown files are written directly in github as md files, and they were copied over from the sdg-strings repo.

A little while ago we talked about changing this part of the site - linking out to a tagged release of the search strings in the github repo (i.e. people view them there), instead of the current solution of copying them over to be shown on the website. Could we do this in the next update? I'm thinking that it might not look as nice, but we avoid having to deal with a) duplicate/copied versions and b) the conversion from markdown. Plus, then I don't have to edit the footnotes of 20 markdown files... :)

Unless there are disadvantages doing it that way that I am overlooking? #113

tarjelavik commented 1 year ago

It is invalid html :-). So the accessibility test fails.

tarjelavik commented 1 year ago

But, yeah, having the text one place is better, but i believe the error must be fixed regardless :-).