SDITools / adobeanalyticsr

R Client for Adobe Analytics API v2.0
Other
18 stars 9 forks source link

Reorganize aw_freeform_table and get_req_data #139

Closed charlie-gallagher closed 2 years ago

charlie-gallagher commented 2 years ago

The name of this branch is a misnomer -- I haven't implemented the "get all rows" feature yet. Instead, this is work I'm doing in preparation for that feature.

Summary

This is going towards a simpler, more digestible implementation. Once we have that, we can extend features more easily.

I did not try to implement the "all rows" feature yet. This is a little tricky, because of how it interacts with the recursive nature of the function. Hence, simplifying things is where I wanted to start.

For more, read the descriptions of the commits.

Checklist

charlie-gallagher commented 2 years ago

@benrwoodard do you have some time to look at this?

benrwoodard commented 2 years ago

@charlie-gallagher I will do my final review before the end of the week.

charlie-gallagher commented 2 years ago

@benrwoodard Greatly appreciated!