SDITools / adobeanalyticsr

R Client for Adobe Analytics API v2.0
Other
18 stars 9 forks source link

deprecate_warn("aw_get_metrics(arg)") #143

Closed XoliloX closed 2 years ago

XoliloX commented 2 years ago

Dear Ben,

I assume this error is not related to the package, but after some research, I'm unable to get to the bottom of it. Basically, calling aw_freeform_table() gives me this:

Internal error: what must refer to arguments in the LHS of `=`.

  # Good:
  deprecate_warn("aw_get_metrics(arg = )")

  # Bad:
  deprecate_warn("aw_get_metrics(arg)")

The only fonction I was able to run without that error was the aw_anomaly_report. Would you be able to help me out?

In advance, thanks a lot for your answer!

Best, D.

System : R Studio 1.4.1103, Mac OS 10.15,

XoliloX commented 2 years ago

Dear Charlie,

Thanks for commenting! So there's nothing I can do on my end to pull data before this is solved?

Thanks, D.

charlie-gallagher commented 2 years ago

Hey so I'm not sure, it seems like a plain error on our part--but this deprecation has been in the works for a while so if you don't mind switching the to development version once that mr gets merged, we'll push an update to CRAN fairly soon. I think that's the short-term plan. I haven't looked into the particular issue yet though to see if it's a versioning thing or something else--I at least don't see the same error

XoliloX commented 2 years ago

Hi Charlie, thanks a lot !

Sure, but sorry for the newbie question; is it a package version or another package I should use for the dev one?

Thanks, D.

benrwoodard commented 2 years ago

I'm not able to reproduce the error either on my side. I've never seen a warning cause and error like this. I'll merge the update today and let you know when it is done and how to install the dev version of the package using the 'devtools' package.

XoliloX commented 2 years ago

Hi Ben, great, thanks a lot !!!

Best, D.

charlie-gallagher commented 2 years ago

@benrwoodard I merged it myself a moment ago, since I think it wasn't too big a change or hard to roll back.

No worries @XoliloX! You can install the dev version with the remotes package. The "dev" version is just the GitHub master branch in our case. These are mostly stable changes that have not yet been sent to CRAN.

# install.packages("remotes")    # If you don't have the remotes package installed yet
remotes::install_github("benrwoodard/adobeanalyticsr")
benrwoodard commented 2 years ago

@charlie-gallagher Yes! Thanks for doing that. Let us know @XoliloX what you find. Make sure to restart your R session once you install the dev version of the package.

XoliloX commented 2 years ago

Hi Ben, I can't install the dev version, I have errors because of httr and it seems to be related to RCurl. I'm still investigating that.

benrwoodard commented 2 years ago

Feel free to copy the errors you are getting and we can maybe help you troubleshoot. Sounds like there is a conflict with other packages that are causing some of these issues.

XoliloX commented 2 years ago

Hi Ben, I fixed it ; R version was 4.0.5 was the problem. It's all working well now, sorry for the disturbance! Thanks for your help! Best, D.