Update get_req_data.R - Githubissues

elalbaicin commented 1 year ago

I tried to request some metrics that had character values rather than numeric values, and the extraction would fail. This should solve the problem.

benrwoodard commented 1 year ago

I'm assuming this produces NA values. Can you give an example of the types of character values you had?

elalbaicin commented 1 year ago

"0" and "Infinity". Both come from calculated metrics defined as ratios.

From: Ben Woodard @.> Sent: Wednesday, January 25, 2023 17:18 To: benrwoodard/adobeanalyticsr @.> Cc: Maurício Schwartsman @.>; Author @.> Subject: Re: [benrwoodard/adobeanalyticsr] Update get_req_data.R (PR #153)

I'm assuming this produces NA values. Can you give an example of the types of character values you had?

— Reply to this email directly, view it on GitHubhttps://bra01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fbenrwoodard%2Fadobeanalyticsr%2Fpull%2F153%23issuecomment-1404176147&data=05%7C01%7C%7Cc8fe5833c5f64ba72e0e08daff115572%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C638102747183733493%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=NytGgF5cOLMNefPvboqK3GD0yK%2BdJ4v4QUz0iN8ktTQ%3D&reserved=0, or unsubscribehttps://bra01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAQBAH5WFIVFMCRLZLHOL2ETWUGDBTANCNFSM6AAAAAAUFUCEP4&data=05%7C01%7C%7Cc8fe5833c5f64ba72e0e08daff115572%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C638102747183889715%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=EG03jZFnq3LPO4DWaTnvlFS5bdJ4NclY4qnozRmRnWA%3D&reserved=0. You are receiving this because you authored the thread.Message ID: @.***>

benrwoodard commented 1 year ago

That makes a lot of sense now. Thank you for the pr!

SDITools / adobeanalyticsr

Update get_req_data.R #153