SDITools / adobeanalyticsr

R Client for Adobe Analytics API v2.0
Other
18 stars 9 forks source link

aw_getmetrics() -- change `expansion` to accept a vector #43

Closed gilliganondata closed 3 years ago

gilliganondata commented 3 years ago

It seems a lot more natural to pass multiple values as a vector rather than as a comma-delimited string.

Current example:

expansion = "tags, categories"

Proposed update:

`expansion = c("tags", "categories")

Overall, this seems like a pretty dumb argument. I don't know what use case Adobe was imagining with this. But, I'm seeing this same thing on some other functions and will log separate issues there.

For now, I'm documenting against the current functionality, but, if we implement these enhancements, we'll need to update the documentation accordingly.