SDITools / adobeanalyticsr

R Client for Adobe Analytics API v2.0
Other
18 stars 9 forks source link

Convert arguments that accept a "comma-separated string" to accept a vector instead. #47

Closed gilliganondata closed 3 years ago

gilliganondata commented 3 years ago

Currently, the following argument in aw_get_calculatedmetrics() will only include the tags column:

expansion = "tags, modified"

The following, however, will return both tags and modified:

expansion = "tags,modified"

This is because the space after the comma in the first example means that the second value does not get properly passed to the API.

I would actually prefer the following notation be the actual expected/accepted one:

expansion = c("tags", "modified")

But, at a minimum, using the existing notation but accounting for "comma-space" situations would potentially prevent frustration.

gilliganondata commented 3 years ago

This is also the case for the rsids argument in aw_get_reportsuites() if it's cool to add that to this same issue.

gilliganondata commented 3 years ago

Below is a (hopefully) comprehensive list of where this update should be made. The processing of the function needs to be updated and the function documentation will then need to be updated.

aw_get_calculatedmetrics()

aw_get_dimensions()

[DONE] ~aw_get_metrics()~

aw_get_reportsuites()

aw_get_segments()

benrwoodard commented 3 years ago

updated these to accept c() vectors

gilliganondata commented 3 years ago

Prematurely closed before documentation was updated.