Closed gilliganondata closed 3 years ago
This is also the case for the rsids
argument in aw_get_reportsuites()
if it's cool to add that to this same issue.
Below is a (hopefully) comprehensive list of where this update should be made. The processing of the function needs to be updated and the function documentation will then need to be updated.
aw_get_calculatedmetrics()
rsids
filterByIds
tagnames
expansion
aw_get_dimensions()
expansion
[DONE] ~aw_get_metrics()~
expansion
~aw_get_reportsuites()
rsids
aw_get_segments()
rsids
segmentFilter
expansion
updated these to accept c() vectors
Prematurely closed before documentation was updated.
Currently, the following argument in
aw_get_calculatedmetrics()
will only include the tags column:expansion = "tags, modified"
The following, however, will return both tags and modified:
expansion = "tags,modified"
This is because the space after the comma in the first example means that the second value does not get properly passed to the API.
I would actually prefer the following notation be the actual expected/accepted one:
expansion = c("tags", "modified")
But, at a minimum, using the existing notation but accounting for "comma-space" situations would potentially prevent frustration.