aw_get_calculatedmetrics() - `favorite` shows `0` instead of `FALSE` for the default value

SDITools / adobeanalyticsr

R Client for Adobe Analytics API v2.0

Other

18 stars 9 forks source link

aw_get_calculatedmetrics() - `favorite` shows `0` instead of `FALSE` for the default value #50

Closed gilliganondata closed 3 years ago

gilliganondata commented 3 years ago

favorite is a Boolean. And, in general, 0 = FALSE and 1 = TRUE, but the parameter list shows that this is set to 0.

I actually tried setting it to 1 in a call, and the function returned all calculated metrics. I had to set it to TRUE to get that to work.

I think this is as simple as changing function definition to be favorite = FALSE, but I don't know if there are any downstream ramifications of that.

benrwoodard commented 3 years ago

Changed it to NA as default.