SDITools / adobeanalyticsr

R Client for Adobe Analytics API v2.0
Other
18 stars 9 forks source link

aw_get_calculatedmetric_byid() - cannot get this to work at all #53

Closed gilliganondata closed 3 years ago

gilliganondata commented 3 years ago

May not be a bug, but I just can't get this to work.

The code:

aw_get_calculatedmetric_byid(company_id = company_id,
                                                  id = "cm300008117_5eb9b63009282640d73ca30b")

The id I pulled straight from an aw_get_calculatedmetrics() call. I tried several different values, both calculated metrics I owned and ones that I didn't, and I got a NULL result in all cases.

benrwoodard commented 3 years ago

I saw we remove this. I remember now that theoretically (based on swagger) it should work but it never would in swagger. I figured i was just missing the right id or something. I tried the name and other variables but couldn't find anything to trigger the returned data. The whole idea behind this was that I needed to make pretty names and therefore I was going to use this api call to pull the names into the function but i ended up finding a better method through the main calculated metrics function.
I recommend deleting this function.

gilliganondata commented 3 years ago

I agree. Let's just remove the function. The intent of this function can be wholly accomplished with aw_get_calculatedmetrics() simply by using filterByIds, now that I think of it. Let's kill the function!

On Fri, Nov 27, 2020 at 3:17 PM Ben Woodard notifications@github.com wrote:

I saw we remove this. I remember now that theoretically (based on swagger) it should work but it never would in swagger. I figured i was just missing the right id or something. I tried the name and other variables but couldn't find anything to trigger the returned data. The whole idea behind this was that I needed to make pretty names and therefore I was going to use this api call to pull the names into the function but i ended up finding a better method through the main calculated metrics function. I recommend deleting this function.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/benrwoodard/adobeanalyticsr/issues/53#issuecomment-734973649, or unsubscribe https://github.com/notifications/unsubscribe-auth/AET7RJ73WT2LJMC7BTE4E23SSACNLANCNFSM4UFH7SXA .

benrwoodard commented 3 years ago

This has been brutally killed.