SDITools / adobeanalyticsr

R Client for Adobe Analytics API v2.0
Other
18 stars 9 forks source link

aw_freeform_table() - more detail if a request fails partway through #71

Open gilliganondata opened 3 years ago

gilliganondata commented 3 years ago

I got the following messages when running an aw_freeform_table() query:

Estimated runtime: 318.4sec./5.31min.
1 of 398 possible data requests complete. Starting the next 397 requests.
Request failed [429]. Retrying in 7 seconds...
A total of 1985 rows have been pulled.

There is no information about the failed request:

At a minimum, something like the following would be reassuring:

Estimated runtime: 318.4sec./5.31min.
1 of 398 possible data requests complete. Starting the next 397 requests.
Request failed [429]. Retrying in 7 seconds...
Retry successful. Continuing with additional requests...
A total of 1985 rows have been pulled.
charlie-gallagher commented 2 years ago

I'm not sure how much control we have over messaging, as the retrying is taken care of by httr::RETRY() (here). But in a recent update we did improve the error messaging significantly to provide better messages when things totally fail.

As long as an error is temporary, it's ok to not know what happened, right? You can mostly assume it was some server error, or temporary internet error.