SDKiller / zyx-phpmailer

PHPMailer integration for Yii2 framework
BSD 3-Clause "New" or "Revised" License
2 stars 5 forks source link

composer.json PHP mailer version #14

Closed Ziggizag closed 6 years ago

Ziggizag commented 6 years ago

SDKiller,

Please, until compatibility issue with PHP Mailer v. 6 remains unresolved, update your composer.json appropriately to prevent dependent library upgrade. It should read:

"require": {
        "yiisoft/yii2": "*",
        "phpmailer/phpmailer": "~5.2",   <------ HERE !!!
        "soundasleep/html2text": "*"
},

Best regards!

SDKiller commented 6 years ago

You are totally right, thank you

Ziggizag commented 6 years ago

@SDKiller - It's a bit nonsense:

"phpmailer/phpmailer": "~5.2.25",

It really should read:

either:

"phpmailer/phpmailer": "~5.2",

or:

"phpmailer/phpmailer": "5.2.25",

Ziggizag commented 6 years ago

IMHO:

"phpmailer/phpmailer": "~5.2",

is a bit more save in case they found some critical bug in this version and updated it to 5.2.26 for instance.

SDKiller commented 6 years ago

@Ziggizag

According to https://getcomposer.org/doc/articles/versions.md#tilde-version-range-

...while ~1.2.3 is equivalent to >=1.2.3 <1.3.0.

Ziggizag commented 6 years ago

Oh - I did not know!

"Keep'on learning" is always true - thank you, Serge!