Fish-Git
commented
3 years ago Inserting the following at the beginning of the function after the variable declarations seems to fix the problem:
if (arn >= USE_ARMODE)
{
arn &= 0xF;
aea_arn = regs->AEA_AR( arn );
}BUT... I'm not sure yet whether that's the correct thing to do or not.
More research is needed.
If anyone else out there has any additional thoughts to share on the subject, I'd be very eager to hear them!
Thanks.
wably
This issue is closely related to Issue #350.
A user has reported that Hercules is crashing for him when the following jobstream is submitted to z/OS 2.2 or greater:
I have been able to reliably reproduce this crash on my Windows system using the latest bleeding edge development version of Hercules, version 4.4.9999.10344-SDL-gf4a8b54b.
HOWEVER... it should be noted that the bug that appears to be causing this crash was introduced into the Hercules code base over 12(!) years ago (by Roger Bowler no less! *`()`**), so the crash should be reproducible by anyone using pretty much any version of Hercules (and any version of z/OS 2.2 or greater of course).
WinDBG
!analyze -vanalysis of the crash dump produces the following:As you can see, Hercules is crashing in the
dat.hfunctionARCH_DEP( maddr_l )(commonly invoked by theMADDRandMADDRLmacros) in its very first test for a TLB Hit.The reason it is crashing is because the value of
arnpassed into the function has the valueUSE_ARMODE | b1(i.e. the value 30 in this particular case: USE_ARMODE (which is #defined to 16) "OR"ed with the operand access register number (which in this particular case was 14)).This causes the
ARCH_DEP( maddr_l )statement:to load a garbage
aea_arnvalue due to theaea_ar_structarray subscript (5 + arn) used by theAEA_ARmacro being way out of bounds, which of course ends up causing the crash the moment the first TLB Hit condition is reached andregs->CR( aea_arn )and/orregs->AEA_COMMON( aea_arn )are evaluated.*`()`** The following two commits introduced the bug:
Revision: ed4d97402623265b30d9f15db1b44fcb5e6e1d91: Author: Roger Bowler
Date: 3/15/2008 5:04:37 PM
Message: Replace ACC_ARMODE by USE_ARMODE for LPTEA
Modified: dat.h
Modified: esame.c
Modified: hconsts.h
Revision: f440c1bcf72faafca18d82055f3c77e6950abfca Author: Roger Bowler
Date: 3/15/2008 5:09:57 PM
Message: Add MVCOS instruction (part 2)
Modified: control.c
Modified: vstore.h
This issue is closely related to Issue #350.