search

SDL-Hercules-390 / hyperion

The SDL Hercules 4.x Hyperion version of the System/370, ESA/390, and z/Architecture Emulator
Other
248 stars 92 forks source link

Fix build errors #412

Closed mtalexander closed 3 years ago

mtalexander commented 3 years ago

The current master branch doesn't build using GCC 8.4 on MacOS Mojave. These changes make it build and it seems to work ok. These may not be the best fixes but they seem plausible and will serve to document the build errors and one way to fix them.

wrljet commented 3 years ago

Mike,

Since I only considered Clang on MacOS, I would like to test this on all my MacOS VMs and on the Mac Mini M1 before we check this in. Which I will try to do quickly.

Thanks, Bill

Fish-Git commented 3 years ago

Bill (@wrljet)

Since I only considered Clang on MacOS, I would like to test this on all my MacOS VMs and on the Mac Mini M1 before we check this in. Which I will try to do quickly.

Have you done this yet? Mike's changes look good to me, so I'd like to get them pulled into Hercules.

wrljet commented 3 years ago

I have not, but I will do so -- very soon.

Bill

Fish-Git commented 3 years ago

I have not, but I will do so -- very soon.

Bill (@wrljet),

How's it going?   :)

I finally have a fix for our GCC issue (full write-up forthcoming), but I need Mike's changes. If you're not done yet (and I presume you're not, otherwise you would have said so), given that Mike's changes are, IMHO, so simple and (to me) non-controversial, if you're as confident as I am that they won't cause problems, I'm inclined to merge his PR as-is, and fixing any problems you might discover later, in a future commit.

Does that sound okay to you? We are so very, very close to having 4.4 ready for release that'd hate having to delay doing so all for the sake of this one untested pull request.

Would you agree with that?

Thanks!

wrljet commented 3 years ago

Fish,

I have tested the proposed changes on various systems, trying to get a mix, and using systems I thought might act up:

I ran into various unrelated issues along the way, so trying everything took way longer than expected.

So, yes, I'm ready to "sign off" on these changes.

I do still have changes I want to get in before a 4.4 is released though. (which I think are important to reduce user questions/issues when building)

Bill

Fish-Git commented 3 years ago
  • Fedora 34, gcc 11.2.1 (works), and Clang 12.0.1 (tests crashed) Clang 12 doesn't work with any version of our sources I tried on Fedora

I'm hoping the problems with later versions of clang are also due to the same Hercules bug I found that was causing our problem with gcc. I guess we'll see once I get Mike's PR merged and all of my own changes as well.

(I'd like to install a newer version of gcc and clang on my Neon system and might(?) need your help with that (unless it's just a simply yum command or something), but that an wait until much later)

So, yes, I'm ready to "sign off" on these changes.

Fantastic! Thanks!

Mike? (@mtalexander)

I am merging you pull request now! Many thanks for your contribution!

p.s. How's MTS?   :)

Fish-Git commented 3 years ago

(@mtalexander)   Closing PR.   Thanks again, Mike!

(But of course if any of you have anything additional you want to say you can of course continue to do so. Nothing prevents one from continuing to post messages to a closed Issue or Pull Request, etc.)

Fish-Git commented 3 years ago

[...]

I do still have changes I want to get in before a 4.4 is released though. (which I think are important to reduce user questions/issues when building)

Now would be a good time! :)

Also, I haven't forgotten about our plan to create a new "developer" branch in our repository either, to keep our future development efforts (e.g. for 4.5 and future releases) separate from the default "master" branch that users would pull/cone from by default. I just haven't had time to experiment with that yet. (We have two dummy "test" repositories specifically designed for such purposes, called "dummytest" and "dummytest-old".)

-- "Fish" (David B. Trout) Software Development Laboratories http://www.softdevlabs.com mail: @.***

mtalexander commented 3 years ago

On 27 Oct 2021, at 19:39, Fish-Git wrote:

p.s. How's MTS? :)

It's coming along although more slowly than I would like. I've got one problem in the HIM emulation to sort out and then it may be nearly ready for another (much larger) pull request. I'll probably have some questions before then.

Mike