search

SDL-Hercules-390 / hyperion

The SDL Hercules 4.x Hyperion version of the System/370, ESA/390, and z/Architecture Emulator
Other
240 stars 90 forks source link

Minor updates #514

Closed JamesWekel closed 1 year ago

JamesWekel commented 1 year ago

Fish,

A couple of minor updates:

  1. remove a build GCC uninitialized warning message in dfp.c.
  2. Fix TRE-02-performance.asm that has 10 missing instruction tests and do some cosmetic cleanup.

Just had to do one more thing...

Jim

Fish-Git commented 1 year ago
  1. remove a build GCC uninitialized warning message in dfp.c.

I'll take care of that myself. Thanks.

  1. Fix TRE-02-performance.asm that has 10 missing instruction tests and do some cosmetic cleanup.

Too late!  :)

I already noticed the same problem myself, so I just committed updates to all of your "performance" tests (CLCLE-04-performance.asm, TRE-02-performance.asm, TRTE-02-performance.asm and TRTRE-02-performance.asm) to use a simple set of macros instead (example below):

https://github.com/SDL-Hercules-390/hyperion/blob/4e0d31e970d8299d8a84bc5cd911332fb547c743/tests/TRTRE-02-performance.asm#L195-L226

https://github.com/SDL-Hercules-390/hyperion/blob/4e0d31e970d8299d8a84bc5cd911332fb547c743/tests/TRTRE-02-performance.asm#L236-L246

https://github.com/SDL-Hercules-390/hyperion/blob/4e0d31e970d8299d8a84bc5cd911332fb547c743/tests/TRTRE-02-performance.asm#L259-L269

This should hopefully fix the problem once and for all.

So you can go ahead and withdraw/delete/close this new Pull Request of yours, because it's not going to be accepted, since your proposed "fix" (except for dfp.c which I'll do myself shortly) has already been implemented!  ;-)  

Fish-Git commented 1 year ago

p.s. I also generated the PDFs using your preferred "Fira Code Medium" 11pt. font without the feedholes too, just to be nice.  ;-)

Fish-Git commented 1 year ago
  1. remove a build GCC uninitialized warning message in dfp.c.

p.s. You might also consider using clang instead of gcc.  It's a much better compiler IMHO.

Doing so won't magically fix the compiler warning you mentioned of course (it will still be issued as a warning even by clang), but you won't get so many other retarded unhelpful warnings with clang as you do with gcc.*`()`**

*`()`** Again, in my personal opinion; "Your Mileage May Vary" as they say.

JamesWekel commented 1 year ago

Thanks Fish. I should have thought of using a macro to generate the instructions!

Jim