search

SDL-Hercules-390 / hyperion

The SDL Hercules 4.x Hyperion version of the System/370, ESA/390, and z/Architecture Emulator
Other
247 stars 92 forks source link

Publish tags for submodules corresponding to Hercules releases #530

Open matoro opened 1 year ago

matoro commented 1 year ago

Hi, I have been packaging the last two releases of this version of Hercules for Gentoo in my overlay (basically a personal repo). I have been using it to test Gentoo s390 guests and it works great (on a PowerPC host, no less).

The official Gentoo repository packages only the original Hercules version which is running into maintenance troubles now: see https://bugs.gentoo.org/show_bug.cgi?id=521032, https://bugs.gentoo.org/show_bug.cgi?id=879629. I would like to get my version of this version into the official repository but right now the main blocker are the way the split-out submodules (crypto, etc) are included. I do have a method for building them from source, but the problem is that there is no indication of what commit of each module corresponds to a given Hercules release. In my overlay, I use 9999 ebuilds, a.k.a. live packages, that just git clone the latest code. This is not allowed in the official repositories for reproducibility purposes.

I see that you make a commit like https://github.com/SDL-Hercules-390/hyperion/commit/8b5342dc4b4258fbb41a0887664c14b5097a593c before a release. Basically, all that I need is some indication of what the corresponding commit in the submodule libraries those binaries are built from. Extra awesome if you could also create git tags in the submodule repositories (for cleaner URLs) but not strictly necessary. Hope this isn't too much of a burden, thank you for the amazing work.

Rhialto commented 1 year ago

With my hat on as packager for pkgsrc, I second this motion. Having clear releases is much better than having to guess which commit to package. If you create tags in the repositories, like for the main hercules repostory, github will make tar files available, and that is much nicer for packaging than having to deal with git.

wrljet commented 1 year ago

Agreed

matoro commented 1 year ago

With my hat on as packager for pkgsrc, I second this motion. Having clear releases is much better than having to guess which commit to package. If you create tags in the repositories, like for the main hercules repostory, github will make tar files available, and that is much nicer for packaging than having to deal with git.

You can already generate tar files from arbitrary commits without needing a git checkout, e.g. https://github.com/SDL-Hercules-390/telnet/archive/commit/729f0b688c1426018112c1e509f207fb5f266efa.tar.gz

It's just better to have a tag to attach it to so we don't have to guess which submodule commit goes with which release tag.

Rhialto commented 1 year ago

You can already generate tar files from arbitrary commits without needing a git checkout,

Ah I guess then that's how it's handled already, I didn't really look into it recently.