Commit 99dbda7 'Add thread-id number to some device trace messages' introduced an error

[mcisho]

The recent commit 99dbda7 Add thread-id number to some device trace messages introduced an error with line 86 of tprintf.c. The compiler is clang version 16.0.5 (Fedora 16.0.5-1.fc38), the line in question is:-

static numtids = 0;             // (number of entries)

And the error is:-

tfprint.c:86:8: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int]
static numtids = 0;             // (number of entries)
~~~~~~ ^
int
1 error generated.

[Fish-Git]

Yeah, yeah, I know.  Sorry.  Careless typo on my part.  (sigh)   I'll be fixing that "soon".

It also has another much more serious problem though, that I'm currently hard at work trying to resolve: it breaks trace-to-file backward compatibility: the ability of the most recent/current version of the trace-to-file feature to be able to read and process a trace file that was created on an older/earlier version of Hercules. (Oops!)

I was so focused on getting the thread information into the device tracing logic, that I forgot to do my backward compatibility testing. I'm really pissed off at myself for having allowed that to happen. <grumble>

Anyway, expect a new commit "soon" (within the next day or three? hopefully?) that fixes both issues.

[Fish-Git]

@mcisho

Should be fixed now.

[mcisho]

Fixed. Thanks.