search

SDL-Hercules-390 / hyperion

The SDL Hercules 4.x Hyperion version of the System/370, ESA/390, and z/Architecture Emulator
Other
240 stars 90 forks source link

Add tests for AP,SP instructions #599

Closed 76bav closed 7 months ago

76bav commented 11 months ago

basic + performance test

Fish-Git commented 11 months ago

Andrey,

What is the reason these tests were created? Do you plan to optimize the instructions? I was not aware that either one had any issues.

76bav commented 11 months ago

Hi David, Yes, I want to optimize these instructions. I expect speed up two times and more on x86-64, depends on CPU. Fist implementation will be for compiler that support int128 (GCC, Clang).

Best regards Andrey.

Fish-Git commented 7 months ago

Closing (rejecting) this PR.  See my most recent comment as to why.

76bav commented 7 months ago

I have decided to REJECT and CLOSE this Pull Request, as IMO it's not needed at this time.

I would expect that once you have actually completed your actual performance improvements themselves, that you would then include these tests as part of that Pull Request too.

That is to say: Your future Pull Request should include both your performance improvements AND these tests too.

Thanks.

Ok.