search

SDL-Hercules-390 / hyperion

The SDL Hercules 4.x Hyperion version of the System/370, ESA/390, and z/Architecture Emulator
Other
237 stars 89 forks source link

Zvector E6 instruction updates #665

Closed JamesWekel closed 3 months ago

JamesWekel commented 3 months ago

Fish,

Here is the latest update for the Z/Vector E6 instructions for your critical 'instructor' review. The first commit is an update to an instruction decoder, just wrong, wrong on my part. zvector2.c now has my first cut for all non-floating point instructions (I have moved these instructions to the end of zvecto2.c). decNumber is now used for all packed decimal arithmetic operations.

The next tasks are tests and more tests but I'm going to take a break for a couple of weeks.

Thanks for your review and comments.

Jim

JamesWekel commented 3 months ago

Fish,

A minor commit: don't have two definitions for the number of decNumber digits!

Jim

Fish-Git commented 3 months ago

A minor commit: don't have two definitions for the number of decNumber digits!

While I haven't begun formal review of your Pull Request yet (I'll eventually get around to it!), I did take a quick peek at it when you first submitted it, and yes, I was going to ask you about that. Glad you fixed it.

JamesWekel commented 3 months ago

Another typo fix! Starting to work on some publishable tests :-)

Jim

JamesWekel commented 3 months ago

Fish,

Thank you for an additional pair of eyes reviewing the request. Much appreciated.

Jim