Fish-Git
commented
2 months ago The next question is are the tests valid or are they just confirming what has been coded?
Yes, that is indeed the critical question. We need to verify the accuracy of the tests on real hardware.
I know that some of our fellow Hercules developers have zPDT systems, so that would be a good place to start I should think. But I'd of course feel much better if we could verify them on actual real iron and not just on another emulator. But let me first take a look at what you got.
I hope that the Hercules_VS.... files are correct.
I'm sure they are, but let me take a look see.
On Linux, 'make check' executes the 16 zvector-e6-... tests and on windows, Bill's hercules-helper builds the branch and executes the tests.
That's good to know. But you should also be able to run any one of our many tests manually by themselves (i.e. individually on demand) too, of course. I'll take a look at that too.
Always appreciates comments.
Let me give what you've got the once over and I'll get back to you.
JamesWekel
Fish,
A Large pull request... tests for instructions in zvector2.c. The next question is are the tests valid or are they just confirming what has been coded? Right now, it's the probably the 2nd option but it's a start.
I hope that the Hercules_VS.... files are correct.
On Linux, 'make check' executes the 16 zvector-e6-... tests and on windows, Bill's hercules-helper builds the branch and executes the tests.
Always appreciates comments.
No rush.
Jim