SDM-TIB / SDM-RDFizer

An Efficient RML-Compliant Engine for Knowledge Graph Construction
https://doi.org/10.5281/zenodo.3872103
Apache License 2.0
107 stars 25 forks source link

Error in subject uri due to @base uri #76

Closed RichDijk closed 2 years ago

RichDijk commented 2 years ago

Describe the bug

With @base <http://base.org#> and

    rr:subjectMap [
        a rr:Subject;
        rr:termType rr:IRI;
        rr:template "http://www.data.nl#mem_{Client_ID}_{Categorie}";
        rr:class vph-g:FreedomRestrictionEvent;
    ];

<http://base.org#>.http://www.data.nl#mem_410314_20031> ...

Expected behavior With RMLmapper: <http://www.data.nl#mem_410314_20031> ....

Used: Windows 10 with latest release rdfizer, rdflib 6.1 and 4.2 give the same result

eiglesias34 commented 2 years ago

Hello @RichDijk,

First of all, thank you for using the SDM-RDFizer. I found the problem and fixed it. Please test it out. Please take into consideration, that I updated the code but not the library. After I get the confirmation that the problem is fixed I will update the library and close this issue.

Thank you again, Enrique Iglesias.

RichDijk commented 2 years ago

Hi Enrique,

Thank you for solving the issue.

I tried to install the latest commit with python -m pip install git+https://github.com/SDM-TIB/SDM-RDFizer.git@916f1412f65260c15f1c884003c35593df2ac2d8

but got an error ERROR: git+https://github.com/SDM-TIB/SDM-RDFizer.git@916f1412f65260c15f1c884003c35593df2ac2d8 does not appear to be a Python project: neither 'setup.py' nor 'pyproject.toml' found.

I must be doing something wrong :(

eiglesias34 commented 2 years ago

Hello,

I haven't updated the library but I will now.

I haven't installed the SDM-RDFizer the way you are installing it. I usually run the code directly. But when using the library I install it with: python3 -m pip install rdfizer This guarantees that the latest version is used.

I hope this works.

RichDijk commented 2 years ago

I was thinking too difficult. Your patch works fine, thank you.

eiglesias34 commented 2 years ago

That is great. I will close the issue now. Thank you again for using the SDM-RDFizer.