search

SDS-Timo / hpl-wallet

GNU General Public License v3.0
0 stars 1 forks source link

Hardcoded items in Makefile #189

Open timohanke opened 6 days ago

timohanke commented 6 days ago

https://github.com/SDS-Timo/hpl-wallet/blob/4f0a3abaeddd2a1f6a87f1b7dd3ca56fc9b50042/Makefile#L30-L33

There are canister ids hard-coded here and elsewhere in the Makefile.

Is there a way to remove them so we don't publish them? Can we give instructions in the README that work along these lines:

  1. Run this command: ... (this command should create and output canister ids)
  2. Copy-paste the canister ids into the Makefile at point XXX
  3. Run make deploy

So that make is split up into two parts. First only produces canister ids, second does the real deployment and between them we can write the canister ids into the Makefile.

Jair-SDSharp commented 6 days ago

DONE!