search

SDWebImage / SDWebImageAVIFCoder

A SDWebImage coder plugin to support AVIF(AV1 Image File Format) image
MIT License
55 stars 14 forks source link

Fix/support libavif v0.7.3 #20

Closed ledyba-z closed 4 years ago

ledyba-z commented 4 years ago

It may resolve #19

Some constants about colors has been renamed in libavif v0.7.3, so I replaced them.

TODO

Currently, we are discussing how should we treat ICC profile (and libavif was released with breaking changes).

In here: https://github.com/AOMediaCodec/av1-avif/issues/84

So some image with ICC profile can't be decoded "correctly" now, but it looks a little difficult to resolve soon, so I left as TODO and will make an issue ( #21 ).

codecov[bot] commented 4 years ago

Codecov Report

Merging #20 into master will increase coverage by 0.73%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #20      +/-   ##
==========================================
+ Coverage   85.27%   86.01%   +0.73%     
==========================================
  Files           6        6              
  Lines        1494     1494              
==========================================
+ Hits         1274     1285      +11     
+ Misses        220      209      -11
Impacted Files Coverage Δ
SDWebImageAVIFCoder/Classes/ColorSpace.m 84.97% <100.00%> (ø)
Example/SDWebImageAVIFCoder/SDViewController.m 88.88% <0.00%> (+40.74%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 08ca46f...a3c8104. Read the comment docs.

ledyba-z commented 4 years ago

How about releasing new version after this PR is merged?

dreampiggy commented 4 years ago

Good work. Thanks.