search

SDWebImage / SDWebImageAVIFCoder

A SDWebImage coder plugin to support AVIF(AV1 Image File Format) image
MIT License
55 stars 14 forks source link

Handling ICC profile in another way. #21

Open ledyba-z opened 4 years ago

ledyba-z commented 4 years ago

Split from #19, #20.

Currently, we are discussing how should we treat ICC profile while encoding/decoding. (In here: AOMediaCodec/av1-avif#84)

After we agree about how should we do, I will rewrite the decoder and encoder according to it.

dreampiggy commented 4 years ago

@ledyba-z Can I release a patch version firstly, to fix the compile issue ?

This sounds need both libavif and SDWebImageAVIFCoder update, may be a minor version bump.

ledyba-z commented 4 years ago

@dreampiggy Yes, please release the new version.

This sounds need both libavif and SDWebImageAVIFCoder update, may be a minor version bump.

Yes, I think "v0.7.0" is better (However, it looks the breaking change in libavif is not released yet as v0.7.4 or v0.8.0).

dreampiggy commented 4 years ago

Seems the breaking change of profile constants was introduced during a patch version release 😅

image

libavif does not follows semversion currently. I can change that into s.dependency 'libavif', '>= 0.7.2' for this.

dreampiggy commented 4 years ago

Released v0.6.1 firstly. This compatible with libavif 0.7.2+

If libavif 0.8 or later do a huge refactory, we can bump into 0.7.0 again.

ledyba-z commented 4 years ago

Oh, sorry. You are right. I just saw only results of git blame :sweat_smile:

libavif does not follows semversion currently. I can change that into s.dependency 'libavif', '>= 0.7.2' for this. If libavif 0.8 or later do a huge refactory, we can bump into 0.7.0 again.

Both LGTM, thanks!