search

SDWebImage / SDWebImageAVIFCoder

A SDWebImage coder plugin to support AVIF(AV1 Image File Format) image
MIT License
55 stars 14 forks source link

Fix the compatible with libavif 0.8+ version #23

Closed dreampiggy closed 3 years ago

dreampiggy commented 3 years ago

@ledyba-z

See libavif changes: https://github.com/AOMediaCodec/libavif/blob/master/CHANGELOG.md

Seems they break all the exists Ncxl profile.

I provide a quick source code fix, but need your help to check again 😂

ledyba-z commented 3 years ago

I'm so really to be late! I missed the notification....

I am going to have a vacation for a week, but after that, I will review it soon! (Recently, I'v been working on other fields, so I forgot iOS APIs a little bit and I can't push approve button today...^^;)

codecov[bot] commented 3 years ago

Codecov Report

Merging #23 (b883892) into master (d942206) will increase coverage by 0.68%. The diff coverage is 92.68%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #23      +/-   ##
==========================================
+ Coverage   86.52%   87.21%   +0.68%     
==========================================
  Files           6        6              
  Lines        1455     1439      -16     
==========================================
- Hits         1259     1255       -4     
+ Misses        196      184      -12
Impacted Files Coverage Δ
SDWebImageAVIFCoder/Classes/ColorSpace.m 89.25% <92.50%> (+2.52%) :arrow_up:
SDWebImageAVIFCoder/Classes/Conversion.m 87.62% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d942206...b883892. Read the comment docs.