Closed ledyba-z closed 4 years ago
Hi. Nice to see your contribution again.
I’ll have a check tomorrow, the CI integration is good (Previously, because of lack of unit test, I just use the Example samples).
A CLI for macOS is OK, we can also use the same test cases like SDWebImage or SDWebImageWebPCoder as well, which is much better for Xcode and can collect code coverage.
Let me just merge and have a try ?
@dreampiggy
Thank you for your review! (and sorry for the late reply...)
we can also use the same test cases like SDWebImage or SDWebImageWebPCoder as well, which is much better for Xcode and can collect code coverage.
I agree. If you need, I will create some additional test images (which are more simple to write unit tests).
The CI runner part, what else should I do to turn on GitHub Actions ?
Just put yaml files to .github/workflows/****.yml
.
Let me just merge and have a try ?
Of course! After this patch will be merged, Github Actions will be turned on.
Hi!
I found some bugs, and fixed:
And also, I added automated tests using github actions, because it is very boring and hard to check all cases by hand.
It checks that:
Result page is here: https://github.com/link-u/SDWebImageAVIFCoder/actions/runs/34667715
If travis-ci is more appropriate, I will port it.
Please take a look!