search

SDWebImage / SDWebImageSwiftUI

SwiftUI Image loading and Animation framework powered by SDWebImage
https://sdwebimage.github.io/SDWebImageSwiftUI
MIT License
2.16k stars 223 forks source link

Add the same overload method for onSuccess API, which introduce the image data arg. Keep the source code compatibility #109

Closed dreampiggy closed 4 years ago

dreampiggy commented 4 years ago

This solve the #104.

By using the overload method, this can keep source code compatibility, so this is marked as 1.x not 2.x.

codecov[bot] commented 4 years ago

Codecov Report

Merging #109 into master will decrease coverage by 1.27%. The diff coverage is 51.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #109      +/-   ##
==========================================
- Coverage   72.86%   71.58%   -1.28%     
==========================================
  Files           9        9              
  Lines         807      834      +27     
==========================================
+ Hits          588      597       +9     
- Misses        219      237      +18
Flag Coverage Δ
#ios 71.58% <51.42%> (-1.28%) :arrow_down:
Impacted Files Coverage Δ
SDWebImageSwiftUI/Classes/WebImage.swift 77.00% <10.00%> (-3.63%) :arrow_down:
SDWebImageSwiftUI/Classes/ImageManager.swift 69.35% <55.55%> (-5.20%) :arrow_down:
SDWebImageSwiftUI/Classes/AnimatedImage.swift 73.60% <75.00%> (-0.29%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8a347dc...f36440f. Read the comment docs.