Closed dreampiggy closed 3 years ago
Merging #178 (d17d44e) into master (e19c35a) will decrease coverage by
0.20%
. The diff coverage is76.92%
.
@@ Coverage Diff @@
## master #178 +/- ##
==========================================
- Coverage 75.00% 74.79% -0.21%
==========================================
Files 11 11
Lines 960 968 +8
==========================================
+ Hits 720 724 +4
- Misses 240 244 +4
Flag | Coverage Δ | |
---|---|---|
ios | 70.87% <76.92%> (-0.19%) |
:arrow_down: |
macos | 74.25% <76.92%> (-0.23%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
SDWebImageSwiftUI/Classes/ImagePlayer.swift | 71.05% <75.00%> (-5.62%) |
:arrow_down: |
SDWebImageSwiftUI/Classes/WebImage.swift | 89.32% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update e19c35a...2935e2b. Read the comment docs.
This close #133
Use
.frame(maxWidth: .infinity)
will cause theTabView
crash. Actually I think this is SwiftUI issue.But anyway, we don't limit the placeholder frame, if you want, limit yourself using
.placeholder { MyView().frame(width: 100) }