search

SDWebImage / SDWebImageSwiftUI

SwiftUI Image loading and Animation framework powered by SDWebImage
https://sdwebimage.github.io/SDWebImageSwiftUI
MIT License
2.18k stars 224 forks source link

Fix AnimatedImage aspectRatio issue when ratio is nil #301

Closed arnauddorgans closed 6 months ago

arnauddorgans commented 6 months ago

As reported by hstdt on https://github.com/SDWebImage/SDWebImageSwiftUI/issues/279 removing _AspectRatioLayout modifier when aspectRatio is nil fixes the issue

dreampiggy commented 6 months ago

I just merge and code garden your changes

Since you do not gain the edit access from your fork repo for this PR (https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork), you'd better click that Allow edits from maintainers.

Actually, only 3 lines changes is enough. No need for temp func.