search

SDWebImage / SDWebImageSwiftUI

SwiftUI Image loading and Animation framework powered by SDWebImage
https://sdwebimage.github.io/SDWebImageSwiftUI
MIT License
2.21k stars 230 forks source link

Fix the issue when dealloc AnimatedImage's native View, the window does not exist and cause Crash #90

Closed dreampiggy closed 4 years ago

dreampiggy commented 4 years ago

image

codecov[bot] commented 4 years ago

Codecov Report

Merging #90 into master will increase coverage by 0.03%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #90      +/-   ##
==========================================
+ Coverage   74.09%   74.12%   +0.03%     
==========================================
  Files           9        9              
  Lines         687      688       +1     
==========================================
+ Hits          509      510       +1     
  Misses        178      178
Flag Coverage Δ
#ios 74.12% <100.00%> (+0.03%) :arrow_up:
Impacted Files Coverage Δ
SDWebImageSwiftUI/Classes/AnimatedImage.swift 72.59% <100.00%> (+0.07%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e8dcfc5...c0f2531. Read the comment docs.