SDWebImage / libwebp-Xcode

A wrapper for libwebp + Xcode project. Support Carthage && CocoaPods && SwiftPM.
56 stars 36 forks source link

Support libweb 1.3.1 version #17

Closed lukewusb closed 1 year ago

lukewusb commented 1 year ago

There is a new version, 1.3.1 of libwebp From the release note:

  • 6/23/2023: version 1.3.1 This is a binary compatible release.
    • security fixes for lossless encoder (#603, chromium: #1420107, #1455619, CVE-2023-1999)

It resolves a security issue CVE-2023-1999. Can libwebp-Xcode support libwebp 1.3.1 ?

Thanks for your support.

dreampiggy commented 1 year ago

😂 Yes...

Maybe we need some subscription and automatic bump to release new version...This always need me to manual release new libwebp on CocoaPods

lukewusb commented 1 year ago

Thank you for your support.

I have try the following setting in the Podfile

pod 'libwebp', :git => 'git@github.com:SDWebImage/libwebp-Xcode.git', :tag => '1.2.4'

I thought if this can work, I can upgrade the libwebp by myself and send the upgrade PR for contributing.

Unfortunately, I encounter the following error after run pod install:

image

I am investigating how to resolve the problem.

Anyway. Thanks for your support. Really appreciated.

lukewusb commented 1 year ago

BTW, Can you disclose the approximate completion time for the upgrade?

dreampiggy commented 1 year ago
You forgot that `:submodule => true`. This repo use Git Submodule, which is not automaticlly enable when using CocoaPods's `:git` syntax...

Or you forgot to `git sumodule update` after you clone this repo (If you use `:path` syntax)

Forgot what I say. The CocoaPods's spec use different repo (The source code repo is not the podspec repo), you need to use syntax:

pod 'libwebp', :podspec => 'https://raw.githubusercontent.com/SDWebImage/libwebp-Xcode/master/libwebp.podspec

dreampiggy commented 1 year ago

Spend 2 hours on how to correct support sharpyuv and release v1.3.0 and v1.3.1

lukewusb commented 1 year ago

Thank you so much.